Ticket #367 (closed task: fixed)

Opened 2 months ago

Last modified 2 months ago

correct pluralization on almanac/comment count

Reported by: nickyg Owned by: rmarianski
Priority: minor Milestone: 1.0 Launch Phase
Component: Almanac (JS) Keywords:
Cc: ejucovy Total Hours: 0.0
Estimated Hours: 0

Description

We currently don't pluralize properly or consistently in various places where we count things.

  • Homepage: "showing 1 communities"; "1 comments"
  • Almanac view: "Stories (6)"; "1 comment" <-- correct!
  • Story-view: "1 comment(s)"

It seems like we have the ability to conditionally add the "s" when we need it, since we're doing it on almanac-view. We should standardize across views.

Change History

Changed 2 months ago by egj

(In [1864]) re #367, make pluralizations consistent. also, fix layout bug on comment form when username is too long

Changed 2 months ago by egj

  • status changed from new to closed
  • resolution set to fixed

Here are the changes I've made (in r1864):

  • Homepage, latest stories widget: "0 comments", "1 comment", "2 comments"
  • Homepage, almanacs widget: "showing 2 communities" or hide the text entirely if there are only 0 or 1 communities (seems like clutter to me when there are so few items)
  • Almanac view: no change to "Stories (6)" since it's at least grammatically appropriate
  • Story view: "1 comment", "2 comments" (entire widget is hidden if there are no comments -- which may not be desireable since it's sort of a big visual element to have coming in and out of existence)
Note: See TracTickets for help on using tickets.